Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable2409] Backport #6690 #6799

Merged
merged 1 commit into from
Dec 10, 2024
Merged

[stable2409] Backport #6690 #6799

merged 1 commit into from
Dec 10, 2024

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]
Copy link

Backport #6690 into stable2409 from alexggh.

See the documentation on how to use this bot.

@alexggh @github-actions
Fix Possible bug: Vote import failed after aggression is enabled (#…
b073ded 
…6690)

After finality started lagging on kusama around 025-11-25 15:55:40
validators started seeing ocassionally this log, when importing votes
covering more than one assignment.
```
Possible bug: Vote import failed
```

That happens because the assumption that assignments from the same
validator would have the same required routing doesn't hold after you
enabled aggression, so you might end up receiving the first assignment
then you modify the routing for it in `enable_aggression` then your
receive the second assignment and the vote covering both assignments, so
the rouing for the first and second assingment wouldn't match and we
would fail to import the vote.

From the logs I've seen, I don't think this is the reason the network
didn't fully recover until the failsafe kicked it, because the votes had
been already imported in approval-voting before this error.

---------

Signed-off-by: Alexandru Gheorghe <[email protected]>
(cherry picked from commit da95345)
@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Dec 9, 2024
Merged
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Dec 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@alexggh alexggh requested review from sandreim, ordian, AndreiEres and alindima and removed request for ordian December 9, 2024 15:42
@alexggh alexggh enabled auto-merge (squash) December 10, 2024 09:46
@EgorPopelyaev EgorPopelyaev merged commit a4083bf into stable2409 Dec 10, 2024
161 of 194 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-6690-to-stable2409 branch December 10, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandreim sandreim sandreim approved these changes

@alexggh alexggh alexggh approved these changes

@AndreiEres AndreiEres AndreiEres approved these changes

@alindima alindima alindima approved these changes

@ordian ordian Awaiting requested review from ordian

Assignees
No one assigned
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alindima @AndreiEres @alexggh @sandreim @EgorPopelyaev