Snowbridge: Ringfence Polkadot Tokens by Agent #6791
Draft
+107
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI pipeline was cancelled due to failure one of the required jobs. |
yrong
reviewed
Dec 8, 2024
Comment on lines
+631
to
+632
| // Ensure that origin location is some consensus system on a sibling parachain | ||
| let (para_id, agent_id) = ensure_sibling::<T>(&origin_location)?; |
There was a problem hiding this comment.
We may need to reanchor the origin_location in context of Ethereum. Same as what we do for the token_location.
https://github.com/alistair-singh/polkadot-sdk/blob/28109f9b7599aabe36448f24eda348f5f0f84e88/bridges/snowbridge/pallets/system/src/lib.rs#L785-L790
Btw: In outbound V2 we add DescribeGlobalPrefix into AgentIdOf.
https://github.com/yrong/polkadot-sdk/blob/bee50a993d335b9a8e6aa4eced62599345b86c34/bridges/snowbridge/primitives/core/src/location.rs#L32
Maybe we need to merge AgentIdOf and TokenIdOf into one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
register_tokento accept an XCM origin, this origin has a corresponding agent on the Ethereum side of the bridge that will become the owner of the token.Related Solidity changes: Snowfork/snowbridge#1350