Migrate pallet-tx-pause to umbrella crate
#6630
Open
+42
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
User @bennethxyz, please sign the CLA here. |
91 tasks
kianenigma
reviewed
Dec 3, 2024
substrate/frame/tx-pause/src/mock.rs
Outdated
| use frame::{ | ||
| prelude::frame_system, | ||
| runtime::{ | ||
| prelude::{ |
There was a problem hiding this comment.
preludes are meant to be imported as prelude::*.
Please read the instructions of the tracking issue as to how to do this migration more carefully.
There was a problem hiding this comment.
@kianenigma There are cases where only one item is needed in the prelude
|
I believe the recent changes follows the guidelines @re-gius |
re-gius
added
R0-silent
re-gius
reviewed
Dec 17, 2024
|
please review @re-gius |
re-gius
approved these changes
Jan 3, 2025
substrate/frame/src/lib.rs
Outdated
| }; | ||
| } | ||
|
|
||
| /// Utility traits not tied to any direct operation in the runtime. |
There was a problem hiding this comment.
I would prefer having those directly inside the right prelude, I don't find any added value in a utility module unless you need to use it in different preludes.
|
Review required! Latest push from author must always be reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6504
polkadot address: 15rM9idTv1izwNFqPabfcT4jkqHDsEvHSa5fASAUZwZcS4Yw