-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate pallet-assets-freezer
to umbrella crate
#6599
Open
runcomet
wants to merge
23
commits into
paritytech:master
Choose a base branch
from
runcomet:umbrella-assets-freezer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+145
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91 tasks
please review @re-gius |
re-gius
added
R0-silent
Changes should not be mentioned in any release notes
T1-FRAME
This PR/Issue is related to core FRAME, the framework.
labels
Dec 9, 2024
please review @re-gius |
from the guidelines polkadot-sdk/substrate/frame/src/lib.rs Lines 148 to 149 in 06a68be
|
kianenigma
reviewed
Jan 3, 2025
pub use sp_runtime::traits::{IdentifyAccount, IdentityLookup}; | ||
} | ||
|
||
/// Utility traits not tied to any direct operation in the runtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
/// Utility traits not tied to any direct operation in the runtime. | |
/// Utility traits not tied to any direct operation in the runtime. | |
/// | |
/// This is already part of the [`prelude`]. |
kianenigma
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6504
Added modules
utility
: Traits not tied to any direct operation in the runtime.polkadot address: 14SRqZTC1d8rfxL8W1tBTnfUBPU23ACFVPzp61FyGf4ftUFg