[stable2409] Backport #6540 #6592
Conversation
![paritytech-cmd-bot-polkadot-sdk[bot]](https://avatars.githubusercontent.com/in/975620?s=60&v=4){kind=small}
|
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-6540-to-stable2409
git worktree add --checkout .worktree/backport-6540-to-stable2409 backport-6540-to-stable2409
cd .worktree/backport-6540-to-stable2409
git reset --hard HEAD^
git cherry-pick -x bf20a9ee18f7215210bbbabf79e955c8c35b3360
git push --force-with-lease |
github-actions
bot
added
the
A3-backport
|
This pull request is amending an existing release. Please proceed with extreme caution,
Emergency Bypass
If you really need to bypass this check: add |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
…ash amount is atleast ED (#6540) This change prevents `pools::apply_slash` from being executed when the pending slash amount of the member is lower than the ED. The issue came to light with the failing [benchmark test](https://github.com/polkadot-fellows/runtimes/actions/runs/11879471717/job/33101445269?pr=490#step:11:765) in Kusama. The problem arises from the inexact conversion between points and balance. Specifically, when points are converted to balance and then back to points, rounding can introduce a small discrepancy between the input and the resulting value. This issue surfaced in Kusama due to its ED being different from Westend and Polkadot (1 UNIT/300), making the rounding issue noticeable. This fix is also significant because applying a slash is feeless and permissionless. Allowing super small slash amounts to be applied without a fee is undesirable. With this change, such small slashes will still be applied but only when member funds are withdrawn. --------- Co-authored-by: Dónal Murray <[email protected]> (cherry picked from commit bf20a9e)
Ank4n
force-pushed
the
backport-6540-to-stable2409
branch
from
21a6b10 to
4d15745
Compare
prdoc/pr_6540.prdoc
Outdated
| - name: pallet-nomination-pools-runtime-api | ||
| bump: patch | ||
| - name: pallet-nomination-pools | ||
| bump: major |
There was a problem hiding this comment.
How do we currently deal with backporting major changes? Something smells about that, depending how far back we go
There was a problem hiding this comment.
@seadanda I assume it will only patch the existing release.
Also, practically this may not be a breaking change (I think). The client gets the new type information from the metadata, and the module error is only really for error description. Changes in Storage or RuntimeCall are more critical as some dapp's business logic may depend on it.
I could make one of the following change if that helps:
- Add the new error variant to the end so existing indexes are not affected.
- The backport version does not add the new error and reuses one of the existing errors.
|
/cmd prdoc --bump patch --audience runtime_user |
|
This pull request is amending an existing release. Please proceed with extreme caution,
Emergency Bypass
If you really need to bypass this check: add |
Backport #6540 into
stable2409from Ank4n.See the documentation on how to use this bot.