Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2407] Backport #6526 #6530

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #6526 into stable2407 from bkchr.

See the documentation on how to use this bot.

Co-authored-by: GitHub Action <[email protected]>
(cherry picked from commit b71bd53)
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Nov 18, 2024
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or trivial (not sure audit).
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

ordian
ordian previously approved these changes Nov 18, 2024
@bkchr bkchr enabled auto-merge (squash) November 18, 2024 22:06
bkchr
bkchr previously approved these changes Nov 18, 2024
@bkchr bkchr disabled auto-merge November 18, 2024 22:07
@bkchr bkchr enabled auto-merge (squash) November 18, 2024 22:07
@bkchr bkchr disabled auto-merge November 19, 2024 14:25
@bkchr bkchr enabled auto-merge (squash) November 19, 2024 14:28
@bkchr
Copy link
Member

bkchr commented Nov 21, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Nov 21, 2024

@bkchr https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7795447 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-836acee4-9b64-4392-a04a-43c4da404464 to cancel this command or bot cancel to cancel all commands in this pull request.

@paritytech-ci paritytech-ci dismissed stale reviews from bkchr and ordian via edabd7d November 21, 2024 12:50
@paritytech-ci paritytech-ci requested review from a team and koute as code owners November 21, 2024 12:50
@command-bot
Copy link

command-bot bot commented Nov 21, 2024

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7795447 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7795447/artifacts/download.

@paritytech-review-bot paritytech-review-bot bot requested a review from a team November 21, 2024 12:51
@bkchr bkchr disabled auto-merge November 21, 2024 13:26
@bkchr bkchr enabled auto-merge (squash) November 21, 2024 13:26
@EgorPopelyaev EgorPopelyaev merged commit b98e0b3 into stable2407 Nov 21, 2024
49 of 108 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-6526-to-stable2407 branch November 21, 2024 13:31
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7796103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants