Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump primitive-types to 0.13.1 #862

Closed
wants to merge 3 commits into from
Closed

Bump primitive-types to 0.13.1 #862

wants to merge 3 commits into from

Conversation

pgherveou
Copy link
Contributor

No description provided.

pgherveou
pgherveou commented Sep 11, 2024
View reviewed changes
primitive-types/Cargo.toml Outdated Show resolved Hide resolved
pgherveou
pgherveou commented Sep 11, 2024
View reviewed changes
primitive-types/Cargo.toml
@@ -11,10 +11,10 @@ rust-version = "1.60.0"

[dependencies]
fixed-hash = { version = "0.8", path = "../fixed-hash", default-features = false }
uint = { version = "0.10.0", path = "../uint", default-features = false }
impl-serde = { version = "0.5.0", path = "impls/serde", default-features = false, optional = true }
impl-codec = { version = "0.6.0", path = "impls/codec", default-features = false, optional = true }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[email protected] was wrong since the macro generates code that uses the latest breaking changes

@pgherveou
Copy link
Contributor Author

pgherveou commented Sep 11, 2024 •
edited
Loading

@ordian I believe we should yank 0.13 and release 0.13.1 instead
This breaks does not build with newest versions because of that

@pgherveou pgherveou requested a review from ordian September 11, 2024 21:56
@ordian
Copy link
Member

ordian commented Sep 12, 2024

@ordian I believe we should yank 0.13 and release 0.13.1 instead This breaks does not build with newest versions because of that

Sorry I don't understand the changes in this PR. version = "0.6.0" means version = "ˆ0.6.0", which is any compatible version with 0.6.0, which include 0.6.1.
https://crates.io/crates/primitive-types/0.13.0/dependencies

Could you elaborate what exactly was wrong?

@pgherveou
Copy link
Contributor Author

@ordian I believe we should yank 0.13 and release 0.13.1 instead This breaks does not build with newest versions because of that

Sorry I don't understand the changes in this PR. version = "0.6.0" means version = "ˆ0.6.0", which is any compatible version with 0.6.0, which include 0.6.1. https://crates.io/crates/primitive-types/0.13.0/dependencies

Could you elaborate what exactly was wrong?

Ha right, I I got that wrong then, I thought it was the source of the issue here paritytech/polkadot-sdk#5673, maybe I can just cargo update this dep and get it to work then

@pgherveou pgherveou closed this Sep 12, 2024
@ordian ordian mentioned this pull request Sep 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ordian ordian Awaiting requested review from ordian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgherveou @ordian