Upgrade rocksdb to 0.22 #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bkchr Could you help to take a look at this? |
jasl
commented
Jul 28, 2024
| @@ -905,7 +905,7 @@ rocksdb.db.get.micros P50 : 2.000000 P95 : 3.000000 P99 : 4.000000 P100 : 5.0000 | |||
| assert!(settings.contains(" block_size: 323232")); | |||
|
|
|||
| // LRU cache (default column) | |||
| assert!(settings.contains("block_cache_options:\n capacity : 8388608")); | |||
| assert!(settings.contains("block_cache_options:\n capacity : 115343360")); | |||
There was a problem hiding this comment.
I haven't checked why it changed here, but this should be OK.
There was a problem hiding this comment.
The cache size was probably changed? Can you maybe check that in the changelogs?
There was a problem hiding this comment.
The change may relate to https://github.com/facebook/rocksdb/blob/main/HISTORY.md#public-api-changes-10
I can dig more if you think this is important
bkchr
approved these changes
Jul 28, 2024
ordian
approved these changes
Aug 10, 2024
ggwpez
approved these changes
Aug 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although Parity has recommended
paritydbfor a long time,polkadot-sdkstill has not started the deprecation process forrocksdb.I think we should give some love to the rocksdb. This PR upgrade to its latest version would help to reduce a few outdated dependencies. for example, bitflags 1.3.0