Equivocation detection loop: Reorganize block checking logic as state machine #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we'll be able to save the state in case of a failure
svyatonik
approved these changes
Sep 12, 2023
serban300
added a commit
to serban300/parity-bridges-common
that referenced
this pull request
Sep 12, 2023
… machine (paritytech#2555) * Split `reconnect_failed_client()` logic * Reorganize block checking logic as state machine This way we'll be able to save the state in case of a failure
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-kusama-bridge/2971/5 |
serban300
added a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
… machine (paritytech#2555) (paritytech#2557) * Split `reconnect_failed_client()` logic * Reorganize block checking logic as state machine This way we'll be able to save the state in case of a failure
serban300
added a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
… machine (paritytech#2555) (paritytech#2557) * Split `reconnect_failed_client()` logic * Reorganize block checking logic as state machine This way we'll be able to save the state in case of a failure
bkontur
pushed a commit
that referenced
this pull request
May 7, 2024
… machine (#2555) * Split `reconnect_failed_client()` logic * Reorganize block checking logic as state machine This way we'll be able to save the state in case of a failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we'll be able to save the state in case of a failure.
Actually saving the state is not implemented yet. But this PR is a step towards better error handling.
Related to #2377