Start the equivocation detection loop from the complex relayer #2507

serban300 · 2023-08-30T07:44:05Z

Related to #2377

- remove `signer` and `transactions_mortality` and add `tx_params` - change the order of some fields

svyatonik

LGTM. But have you considered adding a separate subcommand for the substrate-relay for starting ED loop? I don't think ED loop depends in any way on complex relay and vice versa. IMO complex relay is already overloaded with functionality (meaning its code configuration is too complex) and maybe it'll be easier to add a separate subcommand?

svyatonik · 2023-08-30T08:21:12Z

...ents/bridges/rialto-parachain-millau/entrypoints/relay-millau-rialto-parachain-entrypoint.sh

@@ -39,5 +39,7 @@ exec /home/user/substrate-relay relay-headers-and-messages millau-rialto-paracha
 	--rialto-parachain-transactions-mortality=64 \
 	--rialto-host rialto-node-alice \
 	--rialto-port 9944 \
+  --rialto-signer //Millau.HeadersAndMessagesRelay \


Spaces -> tabs please :)

serban300 · 2023-08-30T09:10:18Z

LGTM. But have you considered adding a separate subcommand for the substrate-relay for starting ED loop? I don't think ED loop depends in any way on complex relay and vice versa. IMO complex relay is already overloaded with functionality (meaning its code configuration is too complex) and maybe it'll be easier to add a separate subcommand?

Ok, makes sense, will add a different command. I thought it would be safer to start the ED loop inside the complex relayer in order to not forget about it. But it's true that the complex relayer is overloaded with functionality.

This reverts commit b518ef8.

acatangiu · 2023-08-30T09:15:58Z

will add a different command

yes please 👍

(will review code a bit later)

relays/bin-substrate/src/cli/detect_equivocations.rs

relays/bin-substrate/src/cli/mod.rs

svyatonik

LGTM

acatangiu

💯

acatangiu · 2023-08-30T14:14:55Z

relays/client-kusama/src/codegen_runtime.rs

+
+#[allow(dead_code, unused_imports, non_camel_case_types)]
+#[allow(clippy::all)]
+pub mod api {


if we were to move relays to polkadot-sdk repo, we'd no longer need these huge generated files, right?

and we'd have better control on the runtime API version used too

Yes, we'll be able to use the actual runtimes directly from the repo.

acatangiu · 2023-08-30T14:18:52Z

deployments/bridges/rialto-millau/dashboard/prometheus/targets.yml

+  - detect-millau-to-rialto-equivocations:9616
+  - detect-rialto-to-millau-equivocations:9616


acatangiu · 2023-08-30T14:25:36Z

primitives/chain-bridge-hub-cumulus/src/lib.rs

-
-/// Helper trait to define some extra methods on bridge hubs signed extension (and
-/// overcome Rust limitations).
-pub trait BridgeHubSignedExtension {


Once you merge this, please also update polkadot-sdk and fix breaking changes like this one while still fresh in our minds 😄 . (used here)

Ok, I will. I have to merge it to polkadot-staging first. And then will try to update the bridges repo in polkadot-sdk.

acatangiu · 2023-08-30T14:35:39Z

scripts/regenerate_runtimes.sh

@@ -3,5 +3,8 @@
 cd tools/runtime-codegen
 cargo run --bin runtime-codegen -- --from-node-url "wss://rococo-bridge-hub-rpc.polkadot.io:443" > ../../relays/client-bridge-hub-rococo/src/codegen_runtime.rs
 cargo run --bin runtime-codegen -- --from-node-url "http://localhost:20433" > ../../relays/client-rialto-parachain/src/codegen_runtime.rs
+cargo run --bin runtime-codegen -- --from-node-url "wss://rococo-rpc.polkadot.io:443" > ../../relays/client-rococo/src/codegen_runtime.rs


I guess we're fine to use Rococo runtime api for Wococo too.. but taking mental note to look at this if in the future things start failing on Wococo all of a sudden 😆

…ytech#2507) * Impl SubstrateEquivocationDetectionPipeline for Millau * Impl SubstrateEquivocationDetectionPipeline for Rialto * Make BridgeHubSignedExtension more generic * Define generate_report_equivocation_call_builder!() macro * Impl SubstrateEquivocationDetectionPipeline for Rococo * Impl SubstrateEquivocationDetectionPipeline for Wococo * Impl SubstrateEquivocationDetectionPipeline for Kusama * Impl SubstrateEquivocationDetectionPipeline for Polkadot * Complex relayer simplification - remove `signer` and `transactions_mortality` and add `tx_params` - change the order of some fields * Add equivocation detection CLI traits * Complex relayer: start equivocation detectin loop * Update runtimes regeneration script * Equivocation loop: Fix infinite loop * Revert "Complex relayer: start equivocation detectin loop" This reverts commit b518ef8. * Add subcommand for starting the equivocation detection loop * Fixes * Initialize empty metrics for the equivocations detector loop

#2512) * Impl SubstrateEquivocationDetectionPipeline for Millau * Impl SubstrateEquivocationDetectionPipeline for Rialto * Make BridgeHubSignedExtension more generic * Define generate_report_equivocation_call_builder!() macro * Impl SubstrateEquivocationDetectionPipeline for Rococo * Impl SubstrateEquivocationDetectionPipeline for Wococo * Impl SubstrateEquivocationDetectionPipeline for Kusama * Impl SubstrateEquivocationDetectionPipeline for Polkadot * Complex relayer simplification - remove `signer` and `transactions_mortality` and add `tx_params` - change the order of some fields * Add equivocation detection CLI traits * Complex relayer: start equivocation detectin loop * Update runtimes regeneration script * Equivocation loop: Fix infinite loop * Revert "Complex relayer: start equivocation detectin loop" This reverts commit b518ef8. * Add subcommand for starting the equivocation detection loop * Fixes * Initialize empty metrics for the equivocations detector loop

Polkadot-Forum · 2023-09-13T10:01:02Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-kusama-bridge/2971/5

…ytech#2507) (paritytech#2512) * Impl SubstrateEquivocationDetectionPipeline for Millau * Impl SubstrateEquivocationDetectionPipeline for Rialto * Make BridgeHubSignedExtension more generic * Define generate_report_equivocation_call_builder!() macro * Impl SubstrateEquivocationDetectionPipeline for Rococo * Impl SubstrateEquivocationDetectionPipeline for Wococo * Impl SubstrateEquivocationDetectionPipeline for Kusama * Impl SubstrateEquivocationDetectionPipeline for Polkadot * Complex relayer simplification - remove `signer` and `transactions_mortality` and add `tx_params` - change the order of some fields * Add equivocation detection CLI traits * Complex relayer: start equivocation detectin loop * Update runtimes regeneration script * Equivocation loop: Fix infinite loop * Revert "Complex relayer: start equivocation detectin loop" This reverts commit b518ef8. * Add subcommand for starting the equivocation detection loop * Fixes * Initialize empty metrics for the equivocations detector loop

* Impl SubstrateEquivocationDetectionPipeline for Millau * Impl SubstrateEquivocationDetectionPipeline for Rialto * Make BridgeHubSignedExtension more generic * Define generate_report_equivocation_call_builder!() macro * Impl SubstrateEquivocationDetectionPipeline for Rococo * Impl SubstrateEquivocationDetectionPipeline for Wococo * Impl SubstrateEquivocationDetectionPipeline for Kusama * Impl SubstrateEquivocationDetectionPipeline for Polkadot * Complex relayer simplification - remove `signer` and `transactions_mortality` and add `tx_params` - change the order of some fields * Add equivocation detection CLI traits * Complex relayer: start equivocation detectin loop * Update runtimes regeneration script * Equivocation loop: Fix infinite loop * Revert "Complex relayer: start equivocation detectin loop" This reverts commit b518ef8. * Add subcommand for starting the equivocation detection loop * Fixes * Initialize empty metrics for the equivocations detector loop

serban300 added 13 commits August 29, 2023 17:31

Impl SubstrateEquivocationDetectionPipeline for Millau

3e7accc

Impl SubstrateEquivocationDetectionPipeline for Rialto

9e7963c

Make BridgeHubSignedExtension more generic

0bf3070

Define generate_report_equivocation_call_builder!() macro

eebf2a8

Impl SubstrateEquivocationDetectionPipeline for Rococo

700d976

Impl SubstrateEquivocationDetectionPipeline for Wococo

b00be88

Impl SubstrateEquivocationDetectionPipeline for Kusama

c9e65a6

Impl SubstrateEquivocationDetectionPipeline for Polkadot

76b7b65

Complex relayer simplification

8ddfcf6

- remove `signer` and `transactions_mortality` and add `tx_params` - change the order of some fields

Add equivocation detection CLI traits

b966384

Complex relayer: start equivocation detectin loop

b518ef8

Update runtimes regeneration script

8312224

Equivocation loop: Fix infinite loop

b4a988f

serban300 self-assigned this Aug 30, 2023

svyatonik approved these changes Aug 30, 2023

View reviewed changes

Revert "Complex relayer: start equivocation detectin loop"

d6046bb

This reverts commit b518ef8.

Add subcommand for starting the equivocation detection loop

9713367

svyatonik reviewed Aug 30, 2023

View reviewed changes

relays/bin-substrate/src/cli/detect_equivocations.rs Show resolved Hide resolved

svyatonik reviewed Aug 30, 2023

View reviewed changes

relays/bin-substrate/src/cli/mod.rs Show resolved Hide resolved

svyatonik approved these changes Aug 30, 2023

View reviewed changes

serban300 added 2 commits August 30, 2023 14:59

Fixes

44d0c69

Initialize empty metrics for the equivocations detector loop

d660fb5

acatangiu approved these changes Aug 30, 2023

View reviewed changes

serban300 merged commit 3e9592a into paritytech:master Aug 30, 2023

serban300 mentioned this pull request Aug 30, 2023

Backport: Start the equivocation detection loop from the complex relayer (#2507) #2512

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Start the equivocation detection loop from the complex relayer #2507

Start the equivocation detection loop from the complex relayer #2507

serban300 commented Aug 30, 2023

svyatonik left a comment

svyatonik Aug 30, 2023

serban300 commented Aug 30, 2023

acatangiu commented Aug 30, 2023 •

edited

Loading

svyatonik left a comment

acatangiu left a comment

acatangiu Aug 30, 2023

acatangiu Aug 30, 2023

serban300 Aug 30, 2023

acatangiu Aug 30, 2023

acatangiu Aug 30, 2023

serban300 Aug 30, 2023

acatangiu Aug 30, 2023

Polkadot-Forum commented Sep 13, 2023

		- detect-millau-to-rialto-equivocations:9616
		- detect-rialto-to-millau-equivocations:9616

Start the equivocation detection loop from the complex relayer #2507

Start the equivocation detection loop from the complex relayer #2507

Conversation

serban300 commented Aug 30, 2023

svyatonik left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

serban300 commented Aug 30, 2023

acatangiu commented Aug 30, 2023 • edited Loading

svyatonik left a comment

Choose a reason for hiding this comment

acatangiu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Polkadot-Forum commented Sep 13, 2023

acatangiu commented Aug 30, 2023 •

edited

Loading