CMD test #67
Closed
CMD test #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aritytech#6690) After finality started lagging on kusama around 025-11-25 15:55:40 validators started seeing ocassionally this log, when importing votes covering more than one assignment. ``` Possible bug: Vote import failed ``` That happens because the assumption that assignments from the same validator would have the same required routing doesn't hold after you enabled aggression, so you might end up receiving the first assignment then you modify the routing for it in `enable_aggression` then your receive the second assignment and the vote covering both assignments, so the rouing for the first and second assingment wouldn't match and we would fail to import the vote. From the logs I've seen, I don't think this is the reason the network didn't fully recover until the failsafe kicked it, because the votes had been already imported in approval-voting before this error. --------- Signed-off-by: Alexandru Gheorghe <[email protected]>
The dependency on `pallet_balances` doesn't seem to be necessary. At least everything compiles for me without it. Removed this dependency and a few others that seem to be left overs. --------- Co-authored-by: GitHub Action <[email protected]>
|
/cmd bench --runtime westend --pallet pallet_balances |
|
/cmd bench --runtime dev --pallet pallet_balances |
|
/cmd prdoc |
|
Command "prdoc" has failed ❌! See logs here |
|
Command "bench --runtime dev --pallet pallet_balances" has started 🚀 See logs here |
|
Command "bench --runtime westend --pallet pallet_balances" has started 🚀 See logs here |
|
/cmd prdoc |
|
Command "prdoc" has failed ❌! See logs here |
|
/cmd prdoc --pr 6769 |
|
User @actions-user, please sign the CLA here. |
…t pallet_balances'
…aritytech#6690) After finality started lagging on kusama around 025-11-25 15:55:40 validators started seeing ocassionally this log, when importing votes covering more than one assignment. ``` Possible bug: Vote import failed ``` That happens because the assumption that assignments from the same validator would have the same required routing doesn't hold after you enabled aggression, so you might end up receiving the first assignment then you modify the routing for it in `enable_aggression` then your receive the second assignment and the vote covering both assignments, so the rouing for the first and second assingment wouldn't match and we would fail to import the vote. From the logs I've seen, I don't think this is the reason the network didn't fully recover until the failsafe kicked it, because the votes had been already imported in approval-voting before this error. --------- Signed-off-by: Alexandru Gheorghe <[email protected]>
The dependency on `pallet_balances` doesn't seem to be necessary. At least everything compiles for me without it. Removed this dependency and a few others that seem to be left overs. --------- Co-authored-by: GitHub Action <[email protected]>
|
/cmd prdoc --pr 6769 |
|
Command "bench --runtime westend --pallet pallet_balances" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
|
Command "prdoc --pr 6769" has failed ❌! See logs here |
|
Command "bench --runtime dev --pallet pallet_balances" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
|
/cmd prdoc --pr 6769 --force |
|
/cmd prdoc --pr 6768 --force |
|
/cmd prdoc --pr 6767--force |
|
Command "prdoc --pr 6767--force" has failed ❌! See logs here |
|
/cmd prdoc --pr 6767 --force |
|
Command "prdoc --pr 6767 --force" has failed ❌! See logs here |
|
/cmd prdoc --pr 6765 --force |
|
/cmd bench --runtime westend --pallet pallet_balances |
|
/cmd bench --runtime dev --pallet pallet_balances |
|
Command "bench --runtime dev --pallet pallet_balances" has started 🚀 See logs here |
|
Command "bench --runtime westend --pallet pallet_balances" has started 🚀 See logs here |
added 2 commits
December 9, 2024 22:32
…t pallet_balances'
|
Command "bench --runtime dev --pallet pallet_balances" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
|
Command "bench --runtime westend --pallet pallet_balances" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
mordamax
force-pushed
the
master
branch
2 times, most recently
from
6dd4a71 to
72bd8ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.