-
Notifications
You must be signed in to change notification settings - Fork 3
Add support for substrate following uos #75
base: master
Are you sure you want to change the base?
Conversation
src/QrSigner.js
Outdated
}; | ||
if (value.error) { | ||
onError && onError(value.error); | ||
return <div style={style}>Error in encoding: {value.error}</div>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should we do in case the user inputs a wrong network/payload combo? Right now I'm just showing this ugly div, and also added an onError
prop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's reasonable, the burden of correctness is on the API consumer (!== end user) in this case.
Thank you so much for this PR :) |
'0xd7568e5f0a7eda67a82691ff379ac4bba4f9c9b859fe779b5d46363b61ad2db9' | ||
), | ||
action: 'signTransaction', | ||
crypto: 'ed25519', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this in the spec as well, but really dunno how it is relevant. So, I scan the account, the dapp that has that address couldn't care less if it is ed25519/sr25519 or something else. The signer knows and manages the keys.
So basically, the dapp will only send the data through, the mobile signer can sign it with whichever crypto it has created the account with, the dapp really should not need to know or specify crypto.
ethereumLegacy
andsubstrate
@maciejhirsz If I have your green light, I'll start updating docs
Note: to run the example, I did:
TODO: