Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: arguments to search property inside get_response function doesn't work #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yaroslav-borodii
Copy link

@yaroslav-borodii yaroslav-borodii commented Jan 5, 2024

Contact person

@yaroslav-borodii

Description

Priority: Low
Severity: Tiny

Description: according to Pardot_API->get_response() function, argument $args is query arguments (but might contain ignored auth arguments). I tried to make custom call inside my WordPress theme using this function, but I was wondered when it returned me all prospects with all fields.

Expected Result: I can use Pardot_API->get_response() function with custom query arguments.

Actual Result: When I use custom query arguments, it returns me all the prospects with all fields.

Steps:

  1. Try to call function with custom arguments
Pardot_API->get_response(
	'prospect',
	[
		'fields'  => 'email',
	]
);
  1. Check the output
    image
  2. Integrate my solution
  3. Try query again
  4. Check the output
    image

Additional information:
Because of this bug, my code executes ~1000 API Calls to Pardot.
I would be grateful if you can fix it as soon as possible

Copy link

salesforce-cla bot commented Jan 5, 2024

Thanks for the contribution! Before we can merge this, we need @yaroslav-borodii to sign the Salesforce Inc. Contributor License Agreement.

@yaroslav-borodii yaroslav-borodii changed the title fix: arguments to search inside prospect doesn't work fix: arguments to search inside property doesn't work Jan 5, 2024
@yaroslav-borodii yaroslav-borodii changed the title fix: arguments to search inside property doesn't work fix: arguments to search property inside get_response function doesn't work Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant