Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh2-python next #1

Merged
merged 8 commits into from
Mar 26, 2024
Merged

ssh2-python next #1

merged 8 commits into from
Mar 26, 2024

Conversation

enkore
Copy link

@enkore enkore commented Mar 17, 2024

JacobCallahan and others added 8 commits October 3, 2023 09:24
SafeConfigParser has been deprecated since Python 3.2 and was removed
in Python 3.12 entirely.
Per the release notes [1] it is recommended to use the ConfigParser
class now.

Additionally, the readfp method has been removed in favor of read_file.

[1] - https://docs.python.org/3.12/whatsnew/3.12.html#configparser
This included a number of changes related to the CPython API.

I additionally bumped the supported python versions in CI.
Constrained the Cython version to be less than 3.0, but greater than
0.29.34.
Updated the setup.py to account for the updated cythonize parameters.
Also made the appveyor version PEP440 compatible
Rebuilt the project with the latest version of Cython and unbound the
upper limit of Cython. This was a big jump, but now it a good time to
make it.
This commit adds all relevant files from the libssh2 repo, as of commit
631e773, with some additional attribution and licenses.
while specified in the gcc options, this causes the extensions to not
link against libssh2 any more, with predictable outcomes
(i.e. runtime linking errors)
@JacobCallahan
Copy link

@enkore Is your intention with this new organization to take over the pypi packages that are currently under the old org? (Specifically keeping the same names)

@enkore
Copy link
Author

enkore commented Mar 19, 2024

I believe the earliest eligibility date for starting that process would be late 2024. So the next best thing is making new names and assigning them to a PyPI org or at least multiple maintainers to avoid the unit bus factor.

@JacobCallahan
Copy link

@enkore I'm not sure if you've seen, but I've already published an alternate (ssh2-python312 (nasty, i know)) to pypi in the meantime based on my fork.
Also, in my fork, I switched to github actions for the build/publish process instead of relying on CircleCI. I'd recommend the same for these.

Perhaps a way forward would be to get all of this in place to replace the current packages around when Python 3.13 drops in October. In the meantime, you can push alternative versions for ssh-python and parallel-ssh. I can help with some light maintenance, but with the switch to github actions, those tasks should be light.

If that sounds good to you, then I'll accept the invite into this new organization. Otherwise, I can't promise the time investment needed for a more involved role.

@enkore
Copy link
Author

enkore commented Mar 21, 2024

Sounds good to me!

@JacobCallahan JacobCallahan merged commit 569dfb2 into master Mar 26, 2024
@JacobCallahan JacobCallahan deleted the next branch March 26, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants