test: add matrix dimension to run hive tests with experimental flag #10355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgimenez
force-pushed
the
fgimenez/add-hive-experimental-workflow
branch
4 times, most recently
from
6494b86
to
c033dfd
Compare
fgimenez
added
the
C-hivetest
fgimenez
force-pushed
the
fgimenez/add-hive-experimental-workflow
branch
from
c8c030e
to
c8dcbb5
Compare
fgimenez
force-pushed
the
fgimenez/add-hive-experimental-workflow
branch
from
c8dcbb5
to
9de013d
Compare
onbjerg
reviewed
Aug 20, 2024
good point thx, maybe easier to remove a separate workflow when we are done but having everything together will prevent duplication, will push the changes for this |
onbjerg
approved these changes
Aug 21, 2024
| include: [cancun/eip1153] | ||
| - sim: pyspec | ||
| include: [cancun/eip7516] | ||
| # TODO: uncomment when https://github.com/ethereum/hive/issues/1147 is fixed |
There was a problem hiding this comment.
let's create a tracking issue for this if you haven't already
fgimenez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new matrix dimension to run hive tests running the reth client with
--engine.experimentalflag set. It uses a separate file for expected failures with specific results for the experimental engine.I've also taken the opportunity to comment out pyspec tests until ethereum/hive#1147 is fixed
Note: Once the experimental engine is made default we need to remove the experimental engine type from the matrix