-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support for views #132
Conversation
fd03179
to
d470794
Compare
|
ca5d894
to
21c9b32
Compare
That's strange, I would expect this kind of error to not be environment-specific. |
21c9b32
to
fe20bd5
Compare
fe20bd5
to
b1f0fa5
Compare
15128e0
to
2b16c9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! @kysshsy could you please help review here? If it's good with you, I'm happy to merge this.
765eff9
to
83cc9bd
Compare
Thanks for your feedback @kysshsy , I will rethink this pr |
3239fd2
to
eaa0a90
Compare
…on and use pg_analyze_and_rewrite_fixedparams instead
80a5a5a
to
795dc23
Compare
511b8a4
to
f275502
Compare
LGTM! |
Ticket(s) Closed
What
CREATE VIEW AS SELECT ... FROM FOREIGN_TABLE
do not push down to DuckDBWhy
How
In the
process_utility_hook
, push this view to DuckDBTests
test_view_foreign_table
intests/scan.rs