Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed PHP 8.2 deprecations [continuation] #2514

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Fixed PHP 8.2 deprecations [continuation] #2514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcb247d
Fixed PHP 8.2 deprecations
damienmckenna Nov 4, 2023
087fdb3
Fix (unrelated) code style
greg-1-anderson Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Config/DefaultsConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ class DefaultsConfig extends TerminusConfig
*/
protected $source_name = 'Default';

protected $defaults = [];

/**
* DefaultsConfig constructor.
*/
Expand Down
2 changes: 2 additions & 0 deletions src/Config/DotEnvConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ class DotEnvConfig extends TerminusConfig
*/
protected $file;

protected $defaults = [];

/**
* DotEnvConfig constructor.
*/
Expand Down
2 changes: 2 additions & 0 deletions src/Config/EnvConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ class EnvConfig extends TerminusConfig
{
protected $source_name = 'Environment Variable';

protected $defaults = [];

/**
* EnvConfig constructor.
*/
Expand Down
2 changes: 2 additions & 0 deletions src/Config/YamlConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
*/
class YamlConfig extends TerminusConfig
{
protected $defaults = [];

/**
* YamlConfig constructor.
* @param string $yml_path The path to the yaml file.
Expand Down
8 changes: 4 additions & 4 deletions src/Request/Request.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,9 @@ class Request implements

private static $TRACE_ID = null;

/**
* Generate UUID for use as distributed tracing ID and assign to static class variable
*/
/**
* Generate UUID for use as distributed tracing ID and assign to static class variable
*/
public static function generateTraceId()
{
self::$TRACE_ID = vsprintf('%s%s-%s-%s-%s-%s%s%s', str_split(bin2hex(random_bytes(16)), 4));
Expand Down Expand Up @@ -193,7 +193,7 @@ private function createRetryDecider(): callable
$maxRetries,
$logWarning
) {
$logWarningOnRetry = fn(string $reason) => 0 === $retry
$logWarningOnRetry = fn (string $reason) => 0 === $retry
? $logWarning(
sprintf(
'HTTP request %s %s has failed: %s',
Expand Down
Loading