Address comments on #2492 #2499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add missing filterhooks. * Add missing vars for tests. * Fix clone database workflow creation.
|
the diff for this PR ended up still showing commits from master i already pushed to |
| @@ -296,6 +296,7 @@ private function addBuiltInCommandsAndHooks() | |||
| { | |||
| // List of all hooks and commands. Update via 'composer update-class-lists' | |||
| $this->commands = [ | |||
| 'Consolidation\\Filter\\Hooks\\FilterHooks', | |||
There was a problem hiding this comment.
Good find; wonder when this got dropped.
There was a problem hiding this comment.
That didn't... those are more recent changes already on 3.x that I merged back. I closed this PR because I merged the 3.x changes back to Jordan's branch too but they were still showing in this PR, and they're not real changes, so I made a new PR that doesn't show them.
greg-1-anderson
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.