Catch down network exception and non-object responses in fetch #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jms-pantheon
force-pushed
the
missing-object
branch
from
a9c3223 to
8a4700d
Compare
|
Would you please push your branch to pantheon-systems/terminus so that the tests will run? I gave you write access so that you could do this. |
Comment on lines
+97
to
+112
| if (!is_object($model_data)) { | ||
| // For some reason I can't replicate, occasionally $model_data is just a string here. | ||
| $trace = debug_backtrace(); | ||
| $error_message = "Fetch failed {file}:{line} model_data expected as object but returned as {type}."; | ||
| $context = [ | ||
| 'file' => $trace[0]['file'], | ||
| 'line' => $trace[0]['line'], | ||
| 'type' => gettype($model_data), | ||
| ]; | ||
| if (is_string($model_data)) { | ||
| $error_message .= " String value: {string}"; | ||
| $context['string'] = strlen($model_data) > 250 ? substr($model_data, 0, 250) . '...' : $model_data; | ||
| } | ||
| $this->logger->error($error_message, $context); | ||
| break; | ||
| } |
There was a problem hiding this comment.
I'm on board with this. I might even change 106 to is_scalar and add an else that gathered the value via $error_message .= " Value: " . print_r($model_data, true); .. but there might be a chance of print_r() out of memory'ing...
|
@greg-1-anderson @namespacebrian I'm closing this in favor of #2492 on pantheon-systems/terminus |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catching of exceptions arising from two states.
1) Network is completely down.
This would previously give an uncaught exception when doing any operation from Terminus.
That is now caught and handled
2) Invalid network responses.
This I couldn't reproduce, but based on a stack trace found that certain API responses would sometimes come back processed as a string rather than an object while monitoring workflow logs.
Previous uncaught fatal exception:
Since I wasn't able to reproduce this, I added a handler for it to give more details of the error and a clearer failure.