Skip to content

Commit

Permalink
Default max retries var was not defined. (#2529)
Browse files Browse the repository at this point in the history
* Default max retries var was not defined.

* Update version and changelog. [skip ci]
  • Loading branch information
kporras07 authored Jan 11, 2024
1 parent 02acffa commit c702965
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 3 deletions.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
# Change Log
All notable changes to this project will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org)

## 3.3.3-dev -
## 3.3.3 - 2024-01-11

### Fixed

- Undefined variable notice for defaultMaxRetries (#2529)

## 3.3.2 - 2024-01-11

Expand Down
2 changes: 1 addition & 1 deletion config/constants.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
---

# App
TERMINUS_VERSION: '3.3.3-dev'
TERMINUS_VERSION: '3.3.3'

# Connectivity
TERMINUS_HOST: 'terminus.pantheon.io'
Expand Down
2 changes: 1 addition & 1 deletion src/Request/Request.php
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ private function getClient($base_uri = null): ClientInterface
private function createRetryDecider(): callable
{
$config = $this->getConfig();
$maxRetries = $config->get('http_max_retries', $defaultMaxRetries);
$maxRetries = $config->get('http_max_retries', 5);
// Cap max retries at 10.
$maxRetries = $maxRetries > 10 ? 10 : $maxRetries;
$retryBackoff = $config->get('http_retry_backoff', 5);
Expand Down

0 comments on commit c702965

Please sign in to comment.