Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now it working without Uniq ID attribute on select elements #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dirmax
Copy link

@dirmax dirmax commented Sep 20, 2018

No description provided.

@JacobEvelyn
Copy link
Member

Thanks so much for the PR, @dirmax! @parkerfinch will take a look at this tomorrow and we'll try to get it merged quickly!

@parkerfinch
Copy link
Contributor

Thanks for submitting this @dirmax! We ran into a couple issues testing this out, which I think are because the .select2-results__options element can be added outside of the $(el).parent(). I added some more test cases in #16 today and when I tested out the code change here it didn't apply the maximization correctly.

Can you pull the new test.html file and make sure that your changes work as expected? I'm sorry we don't have a better way to test things out here; right now the best approach we have is to replace the script in that file with the new version and make sure the page still behaves as expected. Does that make sense, and is there anything else I can do to help you test out changes?

Base automatically changed from master to main February 16, 2021 16:05
@nagyimre1980
Copy link

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants