Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a howto on determining packages content for an image #474
base: master
Are you sure you want to change the base?
Add a howto on determining packages content for an image #474
Changes from 1 commit
bcf7ee3
d550e85
bf27636
672ddbb
39abe9e
86255c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, just focusing on using the GitHub UI is good enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it depends on the user and what other tools they are used to using.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure! However, IMO this page is way too overwhelming now, with implementations in multiple languages that must be read and understood, copy pasted and run. It's also hard to keep middle-complexity code like this working fine over time, and there's no linting, etc (for example, there's a few linting violations in the python code). If we want to provide people code based support, I think the better way to do that is to make a python package they can quickly
pip install
and run, and that can have tests, etc. For now, let's get rid of the code here?