TST(string dtype): Resolve HDF5 xfails in test_round_trip.py #60627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andas into str_hdf5_round_trip
rhshadrach
added
IO HDF5
mroeschke
reviewed
Dec 30, 2024
| @@ -1949,6 +1950,7 @@ def _write_to_group( | |||
| def _read_group(self, group: Node): | |||
| s = self._create_storer(group) | |||
| s.infer_axes() | |||
| print(type(s), s) | |||
There was a problem hiding this comment.
Suggested change
| print(type(s), s) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Built on top of #60625