Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Fixed type annotations for read_sql_* functions. #60577

Merged
merged 2 commits into from
Dec 15, 2024
Merged

BUG: Fixed type annotations for read_sql_* functions. #60577

merged 2 commits into from
Dec 15, 2024

Conversation

FakeNameSE
Copy link
Contributor

Added dict of dict type to parse_dates union for read_sql_query and read_sql_table to match valid arguments.

@FakeNameSE
Fixed type annotations for read_sql_* functions.
f0867de 
Added dict of dict type to parse_dates union to match valid arguments.
@FakeNameSE
Ran autoformatter.
f384dfc
@FakeNameSE
Copy link
Contributor Author

I did not check off the checklist item for adding an entry to doc/source/whatsnew/vX.X.X.rst because I was not sure which file there to edit. If you would like me to do so, please just let me know which one, and I would be happy to.

@FakeNameSE
Copy link
Contributor Author

These test failures seem to be completely unrelated to my changes (which just fixed some type annotations). Do you recommend rerunning them?

rhshadrach
rhshadrach approved these changes Dec 15, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach
Copy link
Member

I did not check off the checklist item for adding an entry to doc/source/whatsnew/vX.X.X.rst

The type-hints in the pandas repo are internal, so this is not a user-facing change. As such, it does not need any entry in the whatsnew.

@rhshadrach rhshadrach added Typing type annotations, mypy/pyright type checking IO SQL to_sql, read_sql, read_sql_query labels Dec 15, 2024
@rhshadrach rhshadrach added this to the 3.0 milestone Dec 15, 2024
@rhshadrach rhshadrach merged commit d41884b into pandas-dev:main Dec 15, 2024
58 of 59 checks passed
@rhshadrach
Copy link
Member

Thanks @FakeNameSE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
IO SQL to_sql, read_sql, read_sql_query Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

BUG: Type Annotation Inconsistency in read_sql_* Functions
2 participants
@FakeNameSE @rhshadrach