CI: avoid bad combination of pyopenssl and cryptography versions #60462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Dec 2, 2024
ocefpaf
reviewed
Dec 2, 2024
| @@ -56,6 +56,8 @@ dependencies: | |||
| - xlrd>=2.0.1 | |||
| - xlsxwriter>=3.0.5 | |||
| - zstandard>=0.19.0 | |||
| # TEMP to avoid error when the env gets cryptography >= 42 but older pyopenssl | |||
There was a problem hiding this comment.
If that combination is wrong we should do a repo data patch to fix it. I'll investigate this on the conda-forge side.
There was a problem hiding this comment.
@ocefpaf seems there is already a PR for this: conda-forge/conda-forge-repodata-patches-feedstock#913
There was a problem hiding this comment.
Yep. In fact two! conda-forge/conda-forge-repodata-patches-feedstock#918 was just merged and hopefully you don't need this work around.
There was a problem hiding this comment.
Thanks for merging that!
|
I think we can close this PR since this error isn't showing up on main anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are running into conda/conda#13619 (comment) in some of our envs, seeing what it gives to force a newer pyopenssl version.