Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Test .loc #25548 for matched and unmatched indices of Series #60450

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
+20 −0
Open

TST: Test .loc #25548 for matched and unmatched indices of Series #60450

Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0f7a548
Added test for .loc to test setitem on matching indices
dshettyepi Nov 29, 2024
5175288
precommit workflow
dshettyepi Nov 29, 2024
021bdba
modified from np.NaN to np.nan
DhruvBShetty Nov 29, 2024
6c6b25f
Merge branch 'pandas-dev:main' into test_loc_feature
DhruvBShetty Dec 7, 2024
968c6f7
formatting fixes
DhruvBShetty Dec 8, 2024
1563568
Merge branch 'main' into test_loc_feature
DhruvBShetty Dec 15, 2024
f01554c
Merge branch 'pandas-dev:main' into test_loc_feature
DhruvBShetty Dec 22, 2024
a1c5fec
Added result and expected variables
DhruvBShetty Dec 22, 2024
d6604ee
Added result and expected variables for both tests
DhruvBShetty Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions pandas/tests/indexing/test_loc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3297,3 +3297,19 @@ def test_loc_reindexing_of_empty_index(self):
df.loc[Series([False] * 4, index=df.index, name=0), 0] = df[0]
expected = DataFrame(index=[1, 1, 2, 2], data=["1", "1", "2", "2"])
tm.assert_frame_equal(df, expected)

def test_loc_setitem_matching_index(self):
# GH 25548
s = Series(0.0, index=list("abcd"))
s1 = Series(1.0, index=list("ab"))
s2 = Series(2.0, index=list("xy"))

# Test matching indices
s.loc[["a", "b"]] = s1
tm.assert_series_equal(s[["a", "b"]], s1)

# Test unmatched indices
s.loc[["a", "b"]] = s2
tm.assert_series_equal(
s[["a", "b"]], Series([np.nan, np.nan], index=["a", "b"])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you assign result = s[["a", "b"]] and expected = Series([np.nan, np.nan], index=["a", "b"])?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 👍

)
Loading