Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to the latest version of PyData Sphinx Theme #60430

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

partev
Copy link
Contributor

@partev partev commented Nov 27, 2024

upgrade PyData Sphinx Theme from 0.14 to the latest 0.16

it is needed to get the latest font-awesome pack to be able to display the new twitter-x icon.

#60426

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

upgrade PyData Sphinx Theme from 0.14 to the latest 0.16

it is needed to get the latest font-awesome pack to be able to display the new twitter-x icon.

pandas-dev#60426
@mroeschke mroeschke added the Docs label Nov 27, 2024
@partev
Copy link
Contributor Author

partev commented Nov 27, 2024

I can confirm that updating to the latest version of sphinx-theme fixes the issue with "X" icon.
image
the website is available as an artifact here: https://github.com/pandas-dev/pandas/actions/runs/12044327291/artifacts/2242724668

@mroeschke
Copy link
Member

Thanks. Could you run pre-commit over your changes?

update pydata-sphinx-theme to version 0.16 and synchronize with environment.yml
@partev
Copy link
Contributor Author

partev commented Nov 28, 2024

Thanks. Could you run pre-commit over your changes?

@mroeschke all checks are passing except ci/circleci: test-linux-arm build which is failing due to an unrelated issue. All PRs have this build failing.

@mroeschke mroeschke added this to the 3.0 milestone Dec 2, 2024
@mroeschke mroeschke merged commit a14a8be into pandas-dev:main Dec 2, 2024
50 of 51 checks passed
@mroeschke
Copy link
Member

Thanks let's give this a try

@partev partev deleted the patch-2 branch December 2, 2024 19:17
@partev
Copy link
Contributor Author

partev commented Dec 2, 2024

everything seems to be working now!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants