Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG (string dtype): fix where() for string dtype with python storage #60195

Merged

Conversation

jorisvandenbossche
Copy link
Member

Currently where(mask, None) would silently set None in the underlying values, while we only allow setting a string or np.nan/pd.NA.

xref #54792

@jorisvandenbossche jorisvandenbossche added Bug Strings String extension data type and string data labels Nov 5, 2024
@jorisvandenbossche jorisvandenbossche added this to the 2.3 milestone Nov 5, 2024
@mroeschke mroeschke merged commit cf52dec into pandas-dev:main Nov 5, 2024
54 of 55 checks passed
@mroeschke
Copy link
Member

Thanks @jorisvandenbossche

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Nov 5, 2024
@jorisvandenbossche jorisvandenbossche deleted the string-dtype-fix-where-None branch November 5, 2024 20:01
jorisvandenbossche added a commit that referenced this pull request Nov 5, 2024
…or string dtype with python storage) (#60202)

Backport PR #60195: BUG (string dtype): fix where() for string dtype with python storage

Co-authored-by: Joris Van den Bossche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants