DOC: Document attributes of Timedelta #59698 #60171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
requested changes
Nov 6, 2024
| @@ -1893,6 +1893,21 @@ class Timedelta(_Timedelta): | |||
| Values for construction in compat with datetime.timedelta. | |||
| Numpy ints and floats will be coerced to python ints and floats. | |||
|
|
|||
| Attributes | |||
| ---------- | |||
| resolution: Timedelta | |||
| resolution: Timedelta | ||
| Represents the smallest difference between two time units that can be | ||
| represented by the Timedelta object. | ||
| Fixed at 0 days 00:00:00.000000001 (1 nanosecond). |
There was a problem hiding this comment.
I think this is an example? I'd suggest removing this - we don't give examples in the attribute descriptions and it doesn't seem necessary.
Same applies to the two attributes below.
rhshadrach
changed the title
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #59698
Addresses:
pandas.Timedelta
Added the missing explanations (PRO2) for min, max, and resolution.
Removed:
from code_checks.sh