Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String dtype: deprecate the pyarrow_numpy storage option #60152

Conversation

jorisvandenbossche
Copy link
Member

xref #54792

This old string alias "string[pyarrow_numpy]" is being deprecated for just "str" or the explicit pd.StringDtype("pyarrow", na_value=np.nan)

Directly using FutureWarning (it was an experimental opt-in, so not many people will already have been using it, and then we can directly remove it in pandas 3.0)

@jorisvandenbossche jorisvandenbossche added Strings String extension data type and string data Deprecate Functionality to remove in pandas labels Oct 31, 2024
@jorisvandenbossche jorisvandenbossche added this to the 2.3 milestone Oct 31, 2024
@mroeschke mroeschke merged commit 1908f2e into pandas-dev:main Oct 31, 2024
51 checks passed
@mroeschke
Copy link
Member

Thanks @jorisvandenbossche

Copy link

lumberbot-app bot commented Oct 31, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 1908f2eb962e5c8b84483a6f0582b5e32b6f0ee8
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #60152: String dtype: deprecate the pyarrow_numpy storage option'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-60152-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #60152 on branch 2.3.x (String dtype: deprecate the pyarrow_numpy storage option)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

jorisvandenbossche added a commit to jorisvandenbossche/pandas that referenced this pull request Nov 4, 2024
…60152)

* String dtype: deprecate the pyarrow_numpy storage option

* add pyarrow skip

(cherry picked from commit 1908f2e)
@jorisvandenbossche jorisvandenbossche deleted the string-dtype-deprecate-pyarrow_numpy branch November 4, 2024 06:10
@jorisvandenbossche
Copy link
Member Author

Manual backport -> #60173

jorisvandenbossche added a commit that referenced this pull request Nov 4, 2024
…tion (#60152) (#60173)

String dtype: deprecate the pyarrow_numpy storage option (#60152)

* String dtype: deprecate the pyarrow_numpy storage option

* add pyarrow skip

(cherry picked from commit 1908f2e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants