Fixes: [#60084] Added a new file test_timestamp_hash.py #60115
Conversation
| logging.info("Timestamps are equal") | ||
|
|
||
| # Important to Convert to UTC before comparing hash values to avoid Daylight Saving Time (DST) issues | ||
| ts1_utc = ts1.tz_convert('UTC') |
There was a problem hiding this comment.
Converting to UTC before comparing the hashes doesn't replicate the behavior I reported--the bug is one of those "DST issues" that UTC avoids 😄. The reported issue is that the hashes of the original ts1 and ts2 instances, without normalization, don't have the same hash though they compare equal.
There was a problem hiding this comment.
i read through it again. maybe i should stop normalizing timestamps to UTC, and start comparing the hash values in their original timezones.
There was a problem hiding this comment.
Please review https://pandas.pydata.org/docs/development/contributing_codebase.html#test-driven-development on how to pandas prefers its unit tests. This test should be able to be located in an existing file.
mroeschke
added
the
Testing
|
This PR seems to have gone stale. I'll take over this issue thanks! |
|
Closing as the parent issue was closed |
This pull request addresses the problem described in..
The new test file created ensures that 2 timestamp Objects, created from the same String but in the context of different time zones are equal and have the same hash value after converting to Co ordinated universal time(UTC).