BUG: fix #59965 skipna=True operations don't skip NaN in FloatingArrays #59997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cooolheater
commented
Oct 7, 2024
•
cooolheater
commented
- closes BUG: skipna=True operations don't skip NaN in FloatingArrays #59965
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
…oatingArrays
- Issue: The skipna was not properly handled for BaseMaskedArray
- Fix: Added mask for NA values
- Test: Added test to series/test_reductions since the test uses
rhshadrach
reviewed
Oct 9, 2024
cooolheater
force-pushed
the
cooolheater-issue59965
branch
from
c73603f to
cc63891
Compare
rhshadrach
requested changes
Oct 21, 2024
cooolheater
force-pushed
the
cooolheater-issue59965
branch
from
581665a to
edc977e
Compare
rhshadrach
requested changes
Oct 24, 2024
| series1 = Series({"a": 0.0, "b": 1, "c": 1}, dtype="Float64") | ||
| series2 = Series({"a": 0.0, "b": 2, "c": 2}, dtype="Float64") | ||
| result = series1 / series2 | ||
| assert pd.notna(result.mean(skipna=True)) |
There was a problem hiding this comment.
Nit: can you assert the value here (it is a slightly stronger test). Can use np.isclose.
mroeschke
added
Reduction Operations
|
Apologies @cooolheater - based on the discussion in the linked issue, I think we have to hold off making changes here until a consensus is reached on how to handle various NA values across pandas. There is already a PDEP in progress for this, but it will likely be quite some time until we're ready for this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.