DEPR: disallow parsing datetimes with mixed time zones unless utc=True
#57275
Conversation
simonjayhawkins
added
Datetime
|
@MarcoGorelli, could you please take a look at this PR? |
pandas/core/tools/datetimes.py
Outdated
| with mixed time zones unless ``utc=True``. Parsing datetimes with mixed | ||
| time zones, please specify ``utc=True`` to opt in to the new behaviour. |
There was a problem hiding this comment.
I think there's a word missing in this sentence? Like, "If parsing"? Also, no need to say "to opt in to the new behaviour" - this is the new behaviour :)
There was a problem hiding this comment.
Thanks for the comment. I corrected the wording as you suggested.
| msg = "cannot parse datetimes with mixed time zones unless `utc=True`" | ||
| with pytest.raises(ValueError, match=msg): | ||
| to_datetime(vec, format="mixed") | ||
| with tm.assert_produces_warning(FutureWarning, match=depr_msg): | ||
| msg = "DatetimeIndex has mixed timezones" | ||
| with pytest.raises(TypeError, match=msg): | ||
| DatetimeIndex(vec) | ||
| DatetimeIndex(vec) |
There was a problem hiding this comment.
if they're both meant to raise, can we do this in two context managers please? else maybe only one of them could raise the error and the test would erroneously pass
instead of
with pytest.raises(ValueError, match=msg):
to_datetime(vec, format="mixed")
DatetimeIndex(vec)
let's do
with pytest.raises(ValueError, match=msg):
to_datetime(vec, format="mixed")
with pytest.raises(ValueError, match=msg):
DatetimeIndex(vec)
There was a problem hiding this comment.
thanks, I replaced one context manager with two.
I checked, both to_datetime(vec, format="mixed") and DatetimeIndex(vec) raise ValueError: cannot parse datetimes with mixed time zones unless 'utc=True'
| @@ -598,7 +597,9 @@ cpdef array_to_datetime( | |||
| # (with individual dateutil.tzoffsets) are returned | |||
| is_same_offsets = len(out_tzoffset_vals) == 1 | |||
| if not is_same_offsets: | |||
| return _array_to_datetime_object(values, errors, dayfirst, yearfirst) | |||
| raise ValueError( | |||
There was a problem hiding this comment.
I think the comments above should also be revised cc @MarcoGorelli
There was a problem hiding this comment.
sorry, I missed this comment. I replaced it with
# 2) If the offsets are different, then do not force the parsing
# and raise a ValueError: "cannot parse datetimes with
# mixed time zones unless `utc=True`" instead
…n array_to_datetime
|
Thanks @natmokval |
…ue` (pandas-dev#57275) * correct def _array_to_datetime_object, _array_strptime_object_fallback, fix tests * fix tests * correct to_datetime docs, add a note to v3.0.0 * correct to_datetime docs * fix failures in benchmarks/inference.py * fix pre-commit error * correct examples in to_datetime docs * correct to_datetime docs * delete time_different_offset from benchmarks/inference.py as redundant * correct v3.0.0 * removed _array_to_datetime_object and _array_strptime_object_fallback * correct to_datetime docstring, roll back changes in test_suppress_error_output * fix pre-commit error * correct test_to_datetime_mixed_awareness_mixed_types, and a comment in array_to_datetime
xref #54014
enforced deprecation disallowing parsing datetimes with mixed time zones unless user passes
utc=Truetoto_datetime