REGR: groupby.idxmin/idxmax wrong result on extreme values #57046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Bug
Groupby
Regression
mroeschke
reviewed
Jan 24, 2024
|
|
||
|
|
||
| @pytest.mark.parametrize("how", ["idxmin", "idxmax"]) | ||
| @pytest.mark.parametrize("dtype", ["float32", "float64"]) |
There was a problem hiding this comment.
float_numpy_dtype fixture please
mroeschke
reviewed
Jan 24, 2024
Comment on lines
317
to
318
| print(df) | ||
| print(result) |
There was a problem hiding this comment.
Suggested change
| print(df) | |
| print(result) |
mroeschke
reviewed
Jan 24, 2024
| @@ -424,6 +424,7 @@ def _call_cython_op( | |||
| mask=mask, | |||
| result_mask=result_mask, | |||
| is_datetimelike=is_datetimelike, | |||
| **kwargs, | |||
There was a problem hiding this comment.
To pass skipna to group_idxmin_idxmax
There was a problem hiding this comment.
Ah OK and I guess not all these accept skipna (IIRC there was that related issue related skipna, but forgot if it was for groupby ops or not)
There was a problem hiding this comment.
Yea - I'm planning on turning #56939 into a tracking issue on adding skipna consistently throughout groupby. Can include removing these kwargs as part of that.
…ndas into reg_groupby_idxmin
# Conflicts: # doc/source/whatsnew/v2.2.1.rst
WillAyd
approved these changes
Jan 25, 2024
mroeschke
approved these changes
Jan 26, 2024
|
Thanks @rhshadrach |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 26, 2024
…t on extreme values
mroeschke
pushed a commit
that referenced
this pull request
Jan 26, 2024
… result on extreme values) (#57086) Backport PR #57046: REGR: groupby.idxmin/idxmax wrong result on extreme values Co-authored-by: Richard Shadrach <[email protected]>
3 tasks
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…v#57046) * WIP * REGR: groupby.idxmin/idxmax wrong result on extreme values * fixes * NumPy 2.0 can't come soon enough * fixup * fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idxmaxgroupby aggregation on uint column #57040 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.While working on this, I noticed that the
skipnaargument was also being ignored.The only way I see solving this is adding a
seenBoolean array instead of the sentinel values. cc @WillAyd