BUG: assert_series_equal not properly respecting check-dtype #56654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Dec 28, 2023
| @pytest.mark.parametrize("val", [3, 3.5]) | ||
| def test_ea_and_numpy_no_dtype_check(val, check_exact): | ||
| # GH#56651 | ||
| left = Series([1, 2, val]) |
There was a problem hiding this comment.
Could you also parameterize where this is dtype=object too? I think that should pass this test too?
There was a problem hiding this comment.
Done, and yes this works too
mroeschke
approved these changes
Dec 28, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Dec 28, 2023
…especting check-dtype
phofl
added a commit
that referenced
this pull request
Dec 28, 2023
…erly respecting check-dtype) (#56668) Backport PR #56654: BUG: assert_series_equal not properly respecting check-dtype Co-authored-by: Patrick Hoefler <[email protected]>
cbpygit
pushed a commit
to cbpygit/pandas
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.