Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: avoid special-casing in agg_series #56540

Merged
merged 1 commit into from
Dec 18, 2023
Merged

REF: avoid special-casing in agg_series #56540

merged 1 commit into from
Dec 18, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jbrockmendel jbrockmendel mentioned this pull request Dec 17, 2023
Open
rhshadrach
rhshadrach approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mroeschke mroeschke added this to the 2.2 milestone Dec 18, 2023
@mroeschke mroeschke added the Refactor Internal refactoring of code label Dec 18, 2023
@mroeschke mroeschke merged commit 43f3dde into pandas-dev:main Dec 18, 2023
48 checks passed
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-from_sequence-6 branch December 18, 2023 17:59
cbpygit pushed a commit to cbpygit/pandas that referenced this pull request Jan 2, 2024
@jbrockmendel @cbpygit
REF: avoid special-casing in agg_series (pandas-dev#56540)
7ba1afb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Refactor Internal refactoring of code
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @mroeschke @rhshadrach