Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Adjust excel tests for new string option #56534

Merged
merged 2 commits into from
Dec 18, 2023
Merged

TST: Adjust excel tests for new string option #56534

merged 2 commits into from
Dec 18, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Dec 17, 2023

No description provided.

@phofl phofl added the Strings String extension data type and string data label Dec 17, 2023
@rhshadrach rhshadrach added the IO Excel read_excel, to_excel label Dec 18, 2023
rhshadrach
rhshadrach approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach changed the title Adjust excel tests for new string option TST: Adjust excel tests for new string option Dec 18, 2023
@rhshadrach rhshadrach added this to the 2.2 milestone Dec 18, 2023
@rhshadrach rhshadrach merged commit 5f4b45f into pandas-dev:main Dec 18, 2023
48 checks passed
@rhshadrach
Copy link
Member

Thanks @phofl

@phofl phofl deleted the excel_tests branch December 18, 2023 17:57
cbpygit pushed a commit to cbpygit/pandas that referenced this pull request Jan 2, 2024
@phofl @cbpygit
TST: Adjust excel tests for new string option (pandas-dev#56534)
1f000ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
IO Excel read_excel, to_excel Strings String extension data type and string data
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @rhshadrach