-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Update redirects #56511
DOC: Update redirects #56511
Conversation
@datapythonista - to test the redirects, I'm planning to write a crawler that gets the API urls from previous versions of pandas and tries them out on this PR. I just want to make sure something that tests the redirects doesn't exist so I'm not reinventing the wheel. |
/preview |
No preview found for PR #56511. Did the docs build complete? |
/preview |
Website preview of this PR available at: https://pandas.pydata.org/preview/56511/ |
I don't think we implemented any automated testing for the redirects when we added them (this is the commit: 6a745d8). And I'm not aware of any test added later either. Your idea sounds good. I guess we could also analyze the logs of our server, and see for which pages we return a 404 (probably not in an automated way, but to make sure we don't have anything broken as of today). I guess there will be a lot of noise from bots trying paths if we do that, but we can have a look if you want. |
Thanks @datapythonista - I got a script for checking the redirects added to the OP. I'll post results here when this is ready. |
I reworked the script in the OP to check the redirects to work just using the filesystem. It checks for
Right now I'm just limiting the output to |
@datapythonista - With #55632, I think it's likely we'll be reverting #55626 and this will be closed in that case. If that does happen, I plan on putting up a PR fixing the redirects separately. |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Ref: #55626 (comment)
Opening this up as a draft. I've generated the new paths based on what was in the redirects.csv, but I'd like to find some way to test this.
Script for testing redirects