Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix sort_index(axis=1, ignore_index=True) #56487

Merged
merged 4 commits into from
Dec 18, 2023
+15 −6
Merged

BUG: Fix sort_index(axis=1, ignore_index=True) #56487

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d7f64be
BUG: Fix sort_index(axis=1, ignore_index=True)
mroeschke Dec 13, 2023
47ce8b5
Merge remote-tracking branch 'upstream/main' into bug/sort_index
mroeschke Dec 13, 2023
0683b57
Switch condition
mroeschke Dec 13, 2023
5d5aae6
Merge remote-tracking branch 'upstream/main' into bug/sort_index
mroeschke Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion doc/source/whatsnew/v2.2.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -694,9 +694,10 @@ Other
- Bug in :func:`infer_freq` and :meth:`DatetimeIndex.inferred_freq` with weekly frequencies and non-nanosecond resolutions (:issue:`55609`)
- Bug in :meth:`DataFrame.apply` where passing ``raw=True`` ignored ``args`` passed to the applied function (:issue:`55009`)
- Bug in :meth:`DataFrame.from_dict` which would always sort the rows of the created :class:`DataFrame`. (:issue:`55683`)
- Bug in :meth:`DataFrame.sort_index` when passing ``axis="columns"`` and ``ignore_index=True`` raising a ``ValueError`` (:issue:`56478`)
- Bug in rendering ``inf`` values inside a a :class:`DataFrame` with the ``use_inf_as_na`` option enabled (:issue:`55483`)
- Bug in rendering a :class:`Series` with a :class:`MultiIndex` when one of the index level's names is 0 not having that name displayed (:issue:`55415`)
- Bug in the error message when assigning an empty dataframe to a column (:issue:`55956`)
- Bug in the error message when assigning an empty :class:`DataFrame` to a column (:issue:`55956`)
-

.. ***DO NOT USE THIS SECTION***
Expand Down
10 changes: 5 additions & 5 deletions pandas/core/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5352,11 +5352,11 @@ def sort_index(
new_data = self._mgr.take(indexer, axis=baxis, verify=False)

# reconstruct axis if needed
new_data.set_axis(baxis, new_data.axes[baxis]._sort_levels_monotonic())

if ignore_index:
axis = 1 if isinstance(self, ABCDataFrame) else 0
new_data.set_axis(axis, default_index(len(indexer)))
if not ignore_index:
new_axis = new_data.axes[baxis]._sort_levels_monotonic()
else:
new_axis = default_index(len(indexer))
new_data.set_axis(baxis, new_axis)

result = self._constructor_from_mgr(new_data, axes=new_data.axes)

Expand Down
8 changes: 8 additions & 0 deletions pandas/tests/frame/methods/test_sort_index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -994,3 +994,11 @@ def test_sort_index_with_sliced_multiindex():
),
)
tm.assert_frame_equal(result, expected)


def test_axis_columns_ignore_index():
# GH 56478
df = DataFrame([[1, 2]], columns=["d", "c"])
result = df.sort_index(axis="columns", ignore_index=True)
expected = DataFrame([[2, 1]])
tm.assert_frame_equal(result, expected)