DEPS: Bump some code style check dependencies #56438
Conversation
environment.yml
Outdated
| - tokenize-rt # scripts/check_for_inconsistent_pandas_namespace.py | ||
| - pre-commit>=2.15.0 | ||
| - pre-commit>=3.5.0 |
There was a problem hiding this comment.
why not all the way to 3.6.0?
There was a problem hiding this comment.
Ah good point. I see it was just released but we might as well
ci/deps/actions-310.yaml
Outdated
| @@ -58,6 +60,4 @@ dependencies: | |||
| - zstandard>=0.19.0 | |||
|
|
|||
| - pip: | |||
| - adbc-driver-postgresql>=0.8.0 | |||
| - adbc-driver-sqlite>=0.8.0 | |||
There was a problem hiding this comment.
for my edification, why are these getting moved to a different section? no objection, just curious
There was a problem hiding this comment.
IIRC making a conda environment and then installing packages via pip is generally not recommended, especially for non pure Python libraries, because pip doesn't necessarily resolve non-Python sub-dependencies correctly all the time.
|
is there a reason not to bump mypy? looks like we're on 1.4.1 while 1.7.1 is out (OK to call that out of scope) |
|
Thanks @mroeschke!
It requires more changes, see the first commit of #56493 |
* Move adbc to conda forge * Bump asv, flake8, pre-commit * Bump pyright * Undo pyright * Remove broken togglepromt * Remove togglepromt from extensions * Bump precommit, revert mypy * Revert "Move adbc to conda forge" This reverts commit 86fcea4.
No description provided.