fixed issue, multiindex dataframe now created as expected #56415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
requested changes
Dec 9, 2023
pandas/io/json/_json.py
Outdated
| @@ -208,6 +208,16 @@ def to_json( | |||
| indent=indent, | |||
| ).write() | |||
|
|
|||
| if orient == "split" and isinstance(obj, DataFrame) and isinstance(obj.columns, MultiIndex): | |||
There was a problem hiding this comment.
This should probably be handled in the writer, not after the json string is written
There was a problem hiding this comment.
@mroeschke good point, I have just made a new commit with this suggested change; I moved the code to the FrameWriter class
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas/pandas/tests/io/json/test_pandas.py
Line 336 in 46c8da3
doc/source/whatsnew/v2.2.0.rstfile if fixing a bug or adding a new feature.