Adjust groupby tests for string option #56414
Conversation
…nto string_dtype_tests_groupby # Conflicts: # pandas/core/arrays/base.py
…_dtype_tests_groupby # Conflicts: # doc/source/whatsnew/v2.1.2.rst
# Conflicts: # doc/source/whatsnew/v2.1.2.rst
# Conflicts: # doc/source/whatsnew/v2.1.2.rst # pandas/tests/groupby/test_groupby.py
| or isinstance(nulls_fixture, Decimal) | ||
| and Decimal.is_nan(nulls_fixture) |
There was a problem hiding this comment.
Could you add parentheses around the last two conditions here for clarify (I think it's the same behavior)
| @@ -707,7 +709,15 @@ def test_first_multi_key_groupby_categorical(): | |||
| @pytest.mark.parametrize("method", ["first", "last", "nth"]) | |||
| def test_groupby_last_first_nth_with_none(method, nulls_fixture): | |||
| # GH29645 | |||
| expected = Series(["y"]) | |||
| if nulls_fixture is not pd.NA and ( | |||
There was a problem hiding this comment.
I think nulls_fixture is not pd.NA is unnecessary
| @@ -171,7 +171,9 @@ def test_groupby_quantile_with_arraylike_q_and_int_columns(frame_size, groupby, | |||
| def test_quantile_raises(): | |||
| df = DataFrame([["foo", "a"], ["foo", "b"], ["foo", "c"]], columns=["key", "val"]) | |||
|
|
|||
| with pytest.raises(TypeError, match="cannot be performed against 'object' dtypes"): | |||
| with pytest.raises( | |||
| TypeError, match="cannot be performed against 'object' dtypes|No matching" | |||
There was a problem hiding this comment.
What's the full error message for the No matching case?
pandas/tests/groupby/test_apply.py
Outdated
| @@ -37,7 +37,7 @@ def store(group): | |||
| tm.assert_frame_equal(groups[0], expected_value) | |||
|
|
|||
|
|
|||
| def test_apply_index_date(): | |||
| def test_apply_index_date(using_infer_string): | |||
| # multiple groupers, don't re-expand the output space | ||
| # of the grouper | ||
| # gh-14942 (implement) | ||
| # gh-10132 (back-compat) | ||
| # gh-8138 (back-compat) | ||
| # gh-8869 | ||
|
|
||
| if not observed and using_infer_string: | ||
| mark = pytest.mark.xfail(reason="fill_value=0 invalid for string dtype") |
There was a problem hiding this comment.
Should this test be fixed in the future? If so, okay to xfail - otherwise I'd prefer to test for the exception with pytest.raises. xfails have a perf impact on running the tests.
| @@ -844,7 +844,7 @@ def test_groupby_level_index_value_all_na(self): | |||
| columns=["C"], | |||
| dtype="int64", | |||
| ) | |||
| tm.assert_frame_equal(result, expected) | |||
| tm.assert_frame_equal(result, expected, check_index_type=not using_infer_string) | |||
There was a problem hiding this comment.
Can you just change dytpe="object" on L840?
mroeschke
added
Testing
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Is this still needed? |
|
yep, I'll update |
…groupby # Conflicts: # pandas/tests/groupby/test_apply.py # pandas/tests/groupby/test_groupby.py # pandas/tests/groupby/test_numeric_only.py # pandas/tests/groupby/test_raises.py # pandas/tests/groupby/test_reductions.py
|
Closing to clear the queue, but feel free to update and reopen anytime |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.