Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nlargest nsmallest doc #56369

Merged
merged 6 commits into from
Dec 12, 2023
Merged

Update nlargest nsmallest doc #56369

merged 6 commits into from
Dec 12, 2023

Conversation

MainHanzo
Copy link
Contributor

@MainHanzo MainHanzo commented Dec 6, 2023 •
edited
Loading

@rhshadrach rhshadrach mentioned this pull request Dec 7, 2023
Open
5 tasks
@MainHanzo
Copy link
Contributor Author

@rhshadrach thanks for the review, here is the new commit as requested.

@mroeschke mroeschke added the Docs label Dec 7, 2023
@mroeschke mroeschke requested a review from rhshadrach December 7, 2023 17:17
rhshadrach
rhshadrach requested changes Dec 9, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one more request.

rhshadrach
rhshadrach reviewed Dec 9, 2023
View reviewed changes
pandas/core/frame.py Outdated Show resolved Hide resolved
rhshadrach
rhshadrach approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach
Copy link
Member

@MainHanzo - pre-commit is failing with black. If you aren't familiar with pre-commit, see here:

https://pandas.pydata.org/pandas-docs/stable/development/contributing_codebase.html#pre-commit

@MainHanzo
Copy link
Contributor Author

@rhshadrach it’s all right now

@mroeschke mroeschke added this to the 2.2 milestone Dec 12, 2023
@mroeschke mroeschke merged commit 2a02b00 into pandas-dev:main Dec 12, 2023
44 checks passed
@mroeschke
Copy link
Member

Thanks @MainHanzo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

DOC: pd.Series.nlargest(keep='all') does not ignore duplicates when counting the largest values
3 participants
@MainHanzo @rhshadrach @mroeschke