-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: unstack with sort=False fails when used with the level parameter… #56357
Merged
+30
−10
Merged
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3bd4fdf
BUG: unstack with sort=False fails when used with the level parameter…
renanffernando 895b8f8
Merge remote-tracking branch 'upstream/main' into franco-unstack
rhshadrach 86f7017
Minor refactor and cleanup
rhshadrach 61078aa
Merge branch 'main' of https://github.com/pandas-dev/pandas into fran…
rhshadrach 345eb4f
Cleanup & remove test
rhshadrach cff156b
whatsnew
rhshadrach 6edef4f
Merge branch 'main' of https://github.com/pandas-dev/pandas into fran…
rhshadrach 387a550
Merge branch 'main' into franco-unstack
rhshadrach 14f5da6
Merge branch 'main' into franco-unstack
mroeschke 091b6e1
Merge branch 'main' of https://github.com/pandas-dev/pandas into fran…
rhshadrach 436fc8f
Revert test removal
rhshadrach File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test was added in #57487. To fix this bug, we now need to unconditionally do a take in
_make_sorted_values
. I don't think the fact that it shared memory in them=1
case was important - I think that was the only reason this test was added.cc @phofl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep the test, it still ensures correct behavior. You can remove the shares memory assertion, but everything else should still pass. A failure would imply a legit bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing - done. Renamed since
shares_memory
was no longer accurate.