Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add missing parameters to DateOffset classes: Milli, Micro and Nano #56336

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

vinitaparasrampuria
Copy link
Contributor

@vinitaparasrampuria vinitaparasrampuria commented Dec 5, 2023

Updated documentation by

  1. adding missing parameters for offsets classes: Milli, Micro, Nano.
  2. adding parameter description for offset classes: SemiMonthEnd, SemiMonthBegin

@vinitaparasrampuria vinitaparasrampuria changed the title add parameters to milli, micro and nano DOC: add missing parameters to DateOffset classes: Milli, Micro and Nano Dec 5, 2023
Comment on lines 1219 to 1220
Timestamp('2022-12-09 15:00:00.010000')
>>> ts - Milli(n=10)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Timestamp('2022-12-09 15:00:00.010000')
>>> ts - Milli(n=10)
Timestamp('2022-12-09 15:00:00.010000')
>>> ts - Milli(n=10)

Comment on lines 1255 to 1256
Timestamp('2022-12-09 15:00:00.001000')
>>> ts - Micro(n=1000)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Timestamp('2022-12-09 15:00:00.001000')
>>> ts - Micro(n=1000)
Timestamp('2022-12-09 15:00:00.001000')
>>> ts - Micro(n=1000)

Comment on lines 1291 to 1292
Timestamp('2022-12-09 15:00:00.000001')
>>> ts - Nano(n=1000)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Timestamp('2022-12-09 15:00:00.000001')
>>> ts - Nano(n=1000)
Timestamp('2022-12-09 15:00:00.000001')
>>> ts - Nano(n=1000)

@mroeschke mroeschke added Docs Frequency DateOffsets labels Dec 5, 2023
@mroeschke
Copy link
Member

Could you fix the code checks?

@mroeschke mroeschke added this to the 2.2 milestone Dec 6, 2023
@mroeschke mroeschke merged commit c08e7b3 into pandas-dev:main Dec 6, 2023
44 checks passed
@mroeschke
Copy link
Member

Thanks @vinitaparasrampuria

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants