Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: str.split for ArrowDtype with pat=None #56332

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added Strings String extension data type and string data Arrow pyarrow functionality labels Dec 4, 2023
@mroeschke mroeschke added this to the 2.1.4 milestone Dec 4, 2023
Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@phofl phofl merged commit 2718b4e into pandas-dev:main Dec 5, 2023
48 checks passed
Copy link

lumberbot-app bot commented Dec 5, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.1.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 2718b4e702fa7f0698ade48472497fd0afb2398e
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #56332: BUG: str.split for ArrowDtype with pat=None'
  1. Push to a named branch:
git push YOURFORK 2.1.x:auto-backport-of-pr-56332-on-2.1.x
  1. Create a PR against branch 2.1.x, I would have named this PR:

"Backport PR #56332 on branch 2.1.x (BUG: str.split for ArrowDtype with pat=None)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

mroeschke added a commit to mroeschke/pandas that referenced this pull request Dec 5, 2023
@mroeschke mroeschke deleted the bug/str_split/arrow branch December 5, 2023 23:41
mroeschke added a commit that referenced this pull request Dec 6, 2023
* Backport PR #56332: BUG: str.split for ArrowDtype with pat=None

* remove mode note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: .str.split() fails with pyarrow strings
2 participants