Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow c files in src/include for gitignore #56284

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Dec 1, 2023

Projectile in emacs uses .gitignore to consider certain files are part of the project, so any of our extensions in the src/include subfolders were being excluded by our blanket rules on generated .c/.h files

I would imagine this has benefits for VSCode and other editors as well in terms of file discoverability and searching

@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Dec 4, 2023
@mroeschke mroeschke added this to the 2.2 milestone Dec 4, 2023
@mroeschke mroeschke merged commit 1bb4edc into pandas-dev:main Dec 4, 2023
48 checks passed
@mroeschke
Copy link
Member

Thanks @WillAyd

@WillAyd WillAyd deleted the allow-gitignore branch December 4, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants