Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: value_counts not preserving object dtype #56187

Closed
wants to merge 2 commits into from

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 26, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@jbrockmendel
Copy link
Member

Seems likely to conflict with recent deprecation?

@phofl
Copy link
Member Author

phofl commented Nov 27, 2023

Which one?

@phofl
Copy link
Member Author

phofl commented Nov 27, 2023

Ah you mean #56161, hm yeah, that behaviour sucks

We can also just xfail those tests till 3.0

@mroeschke mroeschke added Dtype Conversions Unexpected or buggy dtype conversions Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff labels Nov 27, 2023
@lithomas1
Copy link
Member

What's the plan here?

Anything we want for 2.1.4?

@lithomas1 lithomas1 removed this from the 2.1.4 milestone Dec 8, 2023
@phofl
Copy link
Member Author

phofl commented Dec 8, 2023

fixing in 3.0

@phofl phofl closed this Dec 8, 2023
@phofl phofl deleted the value_counts branch December 8, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants