Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust tests in root directory for new string option #56184

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Adjust tests in root directory for new string option #56184

merged 4 commits into from
Nov 30, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 26, 2023

sits on #56183

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Strings String extension data type and string data Arrow pyarrow functionality labels Nov 27, 2023
@mroeschke mroeschke added this to the 2.2 milestone Nov 30, 2023
@mroeschke mroeschke merged commit 59a1758 into pandas-dev:main Nov 30, 2023
42 checks passed
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the base_tests1 branch November 30, 2023 17:46
phofl added a commit to phofl/pandas that referenced this pull request Dec 7, 2023
@phofl
BUG: mode not preserving object dtype for string option (pandas-dev#5…
ab076c5 
…6184)

* BUG: mode not preserving object dtype for string option

* Adjust tests in root directory for new string option

(cherry picked from commit 59a1758)
@phofl phofl mentioned this pull request Dec 7, 2023
Merged
phofl added a commit to phofl/pandas that referenced this pull request Dec 7, 2023
@phofl
Backport PR pandas-dev#56184 on branch 2.1.x (BUG: mode not preservin…
d1764d4 
…g object dtype for string option) (pandas-dev#56383)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality Strings String extension data type and string data Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @mroeschke