Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add 3.12 builds #56174

Merged
merged 10 commits into from
Nov 30, 2023
Merged

CI: Add 3.12 builds #56174

merged 10 commits into from
Nov 30, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 26, 2023

Some CoW warnings broke for 3.11, so we should test at least CoW for 3.12 as well

@phofl phofl requested a review from mroeschke as a code owner November 26, 2023 00:08
@lithomas1 lithomas1 mentioned this pull request Nov 26, 2023
Closed
5 tasks
mroeschke
mroeschke reviewed Nov 28, 2023
View reviewed changes
ci/deps/actions-312.yaml Outdated Show resolved Hide resolved
mroeschke
mroeschke reviewed Nov 28, 2023
View reviewed changes
pandas/tests/io/excel/test_readers.py
@@ -1437,7 +1437,9 @@ def test_deprecate_bytes_input(self, engine, read_ext):
"byte string, wrap it in a `BytesIO` object."
)

with tm.assert_produces_warning(FutureWarning, match=msg):
with tm.assert_produces_warning(
FutureWarning, match=msg, raise_on_extra_warnings=False
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the extra warning here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a DeprecationWarning that originates in the excel libraries

mroeschke
mroeschke reviewed Nov 28, 2023
View reviewed changes
pandas/tests/io/excel/test_writers.py
FutureWarning, match="use 'date_format' instead"
FutureWarning,
match="use 'date_format' instead",
raise_on_extra_warnings=False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the extra warning here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@mroeschke mroeschke added the CI Continuous Integration label Nov 28, 2023
@lithomas1
Copy link
Member

Can you disable the python dev builds too?

(There should be instructions in that section of the yaml)

@phofl
Copy link
Member Author

phofl commented Nov 29, 2023

Yep done, that should do the trick I think

@lithomas1 lithomas1 added this to the 2.1.4 milestone Nov 29, 2023
lithomas1
lithomas1 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@lithomas1 lithomas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lithomas1 lithomas1 merged commit e2aa710 into pandas-dev:main Nov 30, 2023
44 checks passed
@lithomas1
Copy link
Member

thanks @phofl.

@lumberbot-app Lumberbot (App)
Copy link

lumberbot-app bot commented Nov 30, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.1.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 e2aa710c4abe6329be6c85689e27787868e44cdd
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #56174: CI: Add 3.12 builds'
  1. Push to a named branch:
git push YOURFORK 2.1.x:auto-backport-of-pr-56174-on-2.1.x
  1. Create a PR against branch 2.1.x, I would have named this PR:

"Backport PR #56174 on branch 2.1.x (CI: Add 3.12 builds)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@phofl phofl deleted the 3_12_build branch November 30, 2023 14:56
lithomas1 pushed a commit to lithomas1/pandas that referenced this pull request Dec 4, 2023
@phofl @lithomas1
Backport PR pandas-dev#56174: CI: Add 3.12 builds
f879112
lithomas1 added a commit that referenced this pull request Dec 7, 2023
@lithomas1 @phofl @pre-commit-ci
Backport PR #56174: CI: Add 3.12 builds (#56333)
65723ab 
* Backport PR #56174: CI: Add 3.12 builds

* Update test_arrow.py

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Patrick Hoefler <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke left review comments

@lithomas1 lithomas1 lithomas1 approved these changes

Assignees
No one assigned
Labels
CI Continuous Integration
Projects
None yet
Milestone
2.1.4
Development

Successfully merging this pull request may close these issues.
3 participants
@phofl @lithomas1 @mroeschke